Increment project version to 5.4
#1290
Conversation
The existence of a `5.3` branch implies `master` is `5.4`. Updated version and externalised/centralised.
| file(READ "${CMAKE_CURRENT_SOURCE_DIR}/.github/config.env" ENV_FILE_CONTENTS) | ||
| string(REGEX REPLACE ".*PROJECT_VERSION=([^\n\r]*).*" "\\1" PROJECT_VERSION "${ENV_FILE_CONTENTS}") | ||
| message(STATUS "PROJECT_VERSION = ${PROJECT_VERSION}") |
There was a problem hiding this comment.
I did not like this reading parsing approach. It is error prone. Our users use it from source code, hence it is important that they can compile locally and in most possible environments. Hence, I do not favor making the version yet another github environment variable. Some of our users may not use github but download source zip and build as well.
We may have hazelcast-cpp-client-examples cmake use it from parent cmake or a common CMakelists.in which can be included in both files.
Another alternative would be passing the version from cmake build command but I would rather not leave the version that flexible and leave it to the users and that is yet an extra parameter.
There was a problem hiding this comment.
It’s not GitHub specific, it’s using cmake to parse the existing config file that we also use for GitHub actions. But if you think it’s overengineered, I won’t disagree.
There was a problem hiding this comment.
I think it is over engineered. We can always use cmake include file approach if we want to centralize some contents in cmake file. The version used in examples may not be even needed. Let's evaluate alternative solutions if we want to avoid this dupliation. Currently, version is in main CMakeLists.txt file and and cmake file in examples folder.
JackPGreen
changed the title
5.35.4
The existence of a
5.3branch impliesmasteris5.4.Updated version and externalised/centralised.