Skip to content

Allow remote code repo names to contain "." #11652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 10, 2025
Merged

Allow remote code repo names to contain "." #11652

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c40cbd
allow loading from repo with dot in name
akasharidas Jun 3, 2025
b59241f
put new arg at the end to avoid breaking compatibility
akasharidas Jun 4, 2025
c5bdecf
add test for loading repo with dot in name
akasharidas Jun 9, 2025
e73679f
Merge branch 'main' into allow_dot_in_repo_name
sayakpaul Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions src/diffusers/utils/dynamic_modules_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,12 +154,29 @@ def check_imports(filename):
return get_relative_imports(filename)


def get_class_in_module(class_name, module_path):
def get_class_in_module(pretrained_model_name_or_path, class_name, module_path):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we do:

def get_class_in_module(class_name, module_path, pretrained_model_name_or_path=None):

This will ensure the change is not backward breaking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, I've made the proposed change

"""
Import a module on the cache directory for modules and extract a class from it.
"""
module_path = module_path.replace(os.path.sep, ".")
module = importlib.import_module(module_path)
try:
module = importlib.import_module(module_path)
except ModuleNotFoundError as e:
# This can happen when the repo id contains ".", which Python's import machinery interprets as a directory
# separator. We do a bit of monkey patching to detect and fix this case.
if not (
"." in pretrained_model_name_or_path
and module_path.startswith("diffusers_modules")
and pretrained_model_name_or_path.replace("/", "--") in module_path
):
raise e # We can't figure this one out, just reraise the original error

corrected_path = os.path.join(HF_MODULES_CACHE, module_path.replace(".", "/")) + ".py"
corrected_path = corrected_path.replace(
pretrained_model_name_or_path.replace("/", "--").replace(".", "/"),
pretrained_model_name_or_path.replace("/", "--"),
)
module = importlib.machinery.SourceFileLoader(module_path, corrected_path).load_module()

if class_name is None:
return find_pipeline_class(module)
Expand Down Expand Up @@ -454,4 +471,4 @@ def get_class_from_dynamic_module(
revision=revision,
local_files_only=local_files_only,
)
return get_class_in_module(class_name, final_module.replace(".py", ""))
return get_class_in_module(pretrained_model_name_or_path, class_name, final_module.replace(".py", ""))