Skip to content

[CI][Deps] Uplift CPU/FPGAEMU RT version to 2023.16.6.0.28 #10237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 23, 2023

Conversation

yanfeng3721
Copy link
Contributor

No description provided.

@yanfeng3721 yanfeng3721 requested a review from a team as a code owner July 6, 2023 10:18
@yanfeng3721 yanfeng3721 marked this pull request as draft July 6, 2023 10:19
@yanfeng3721 yanfeng3721 changed the title [CI][Deps] Uplift CPU/FPGAEMU RT version to 2023.15.6.0.28 [CI][Deps] Uplift CPU/FPGAEMU RT version to 2023.16.6.0.28 Jul 6, 2023
@yanfeng3721 yanfeng3721 temporarily deployed to aws July 6, 2023 10:24 — with GitHub Actions Inactive
@yanfeng3721 yanfeng3721 requested a review from tfzhu July 6, 2023 10:26
@yanfeng3721 yanfeng3721 temporarily deployed to aws July 6, 2023 11:03 — with GitHub Actions Inactive
@yanfeng3721 yanfeng3721 marked this pull request as ready for review July 7, 2023 07:32
@yanfeng3721 yanfeng3721 temporarily deployed to aws July 7, 2023 07:40 — with GitHub Actions Inactive
@yanfeng3721 yanfeng3721 temporarily deployed to aws July 7, 2023 08:55 — with GitHub Actions Inactive
@yanfeng3721 yanfeng3721 temporarily deployed to aws July 10, 2023 04:05 — with GitHub Actions Inactive
@yanfeng3721 yanfeng3721 temporarily deployed to aws July 10, 2023 04:43 — with GitHub Actions Inactive
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix pre-commit failures.

@yanfeng3721
Copy link
Contributor Author

Hi @bader, the PreCI shows installing the new OpenCL CPU Runtime failed. Could you please help to check? Thanks.

Installing Intel OpenCL CPU Runtime...
CPU Runtime version 2023-WW27
/runtimes/oclcpu exists and will be removed!
Traceback (most recent call last):
  File "/__w/llvm/llvm/devops/scripts/get_release.py", line 19, in <module>
    release = get_release_by_tag(repo, tag)
  File "/__w/llvm/llvm/devops/scripts/get_release.py", line 6, in get_release_by_tag
    release = urlopen("https://api.github.com/repos/" + repo + "/releases/tags/" + tag).read()
  File "/usr/lib/python3.10/urllib/request.py", line 216, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.10/urllib/request.py", line 525, in open
    response = meth(req, response)
  File "/usr/lib/python3.10/urllib/request.py", line 634, in http_response
    response = self.parent.error(
  File "/usr/lib/python3.10/urllib/request.py", line [56](https://github.com/intel/llvm/actions/runs/5938335482/job/16102718479?pr=10237#step:9:57)3, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.10/urllib/request.py", line 496, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.10/urllib/request.py", line [64](https://github.com/intel/llvm/actions/runs/5938335482/job/16102718479?pr=10237#step:9:65)3, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 403: rate limit exceeded
tar: *.tar.gz: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now

@bader bader merged commit 72b5ecd into intel:sycl Aug 23, 2023
@bader
Copy link
Contributor

bader commented Aug 23, 2023

Hi @bader, the PreCI shows installing the new OpenCL CPU Runtime failed. Could you please help to check? Thanks.

There is nothing unique I can do about this. I restarted CI checks and they passed.

@bader
Copy link
Contributor

bader commented Aug 23, 2023

@yanfeng3721, I see two tests "unexpectedly" pass in Nightly tests on OpenCL CPU: https://github.com/intel/llvm/actions/runs/5946503013/job/16127794742. Could you check if these are caused by the new OpenCL CPU implementation, please?

@aelovikov-intel, do I understand it correctly that pre-commit didn't catch this because we run it on all available devices and these XFAIL marks were ignored?

@aelovikov-intel
Copy link
Contributor

@aelovikov-intel, do I understand it correctly that pre-commit didn't catch this because we run it on all available devices and these XFAIL marks were ignored?

Likely, yes.

@yanfeng3721
Copy link
Contributor Author

@yanfeng3721, I see two tests "unexpectedly" pass in Nightly tests on OpenCL CPU: https://github.com/intel/llvm/actions/runs/5946503013/job/16127794742. Could you check if these are caused by the new OpenCL CPU implementation, please?

Yes, SYCL :: Scheduler/DISABLED_DataMovement.cpp & SYCL :: SubGroup/scan_spirv13.cpp can pass with new OpenCL CPU RT.
The following line should be removed

// Missing GroupNonUniformArithmetic capability on CPU RT
// XFAIL: cpu

@bader
Copy link
Contributor

bader commented Aug 24, 2023

@yanfeng3721, I see two tests "unexpectedly" pass in Nightly tests on OpenCL CPU: https://github.com/intel/llvm/actions/runs/5946503013/job/16127794742. Could you check if these are caused by the new OpenCL CPU implementation, please?

Yes, SYCL :: Scheduler/DISABLED_DataMovement.cpp & SYCL :: SubGroup/scan_spirv13.cpp can pass with new OpenCL CPU RT. The following line should be removed

// Missing GroupNonUniformArithmetic capability on CPU RT
// XFAIL: cpu

Who is fixing this?
Tagging @intel/llvm-reviewers-runtime for awareness.

@yanfeng3721
Copy link
Contributor Author

@yanfeng3721, I see two tests "unexpectedly" pass in Nightly tests on OpenCL CPU: https://github.com/intel/llvm/actions/runs/5946503013/job/16127794742. Could you check if these are caused by the new OpenCL CPU implementation, please?

Yes, SYCL :: Scheduler/DISABLED_DataMovement.cpp & SYCL :: SubGroup/scan_spirv13.cpp can pass with new OpenCL CPU RT. The following line should be removed

// Missing GroupNonUniformArithmetic capability on CPU RT
// XFAIL: cpu

Who is fixing this? Tagging @intel/llvm-reviewers-runtime for awareness.

@jiezzhang is preparing the PR.

@jiezzhang
Copy link
Contributor

@bader I created a PR #10966. Please help to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants