[SYCL][NATIVECPU] Emit subhandler as LLVM IR #10282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d15e825d02adfc03373c3ed71834f2bdf47c57f4.
elizabethandrews
approved these changes
Jul 12, 2023
uwedolinsky
approved these changes
Jul 13, 2023
|
@intel/llvm-gatekeepers hello, I think that this PR is ready to be merged :) |
|
Failure in post-commit: @PietroGhg could you please take a look asap? |
I think that the failure is due to the fact the IR printer is not printing out the basic block name, #10350 should fix it |
bader
pushed a commit
that referenced
this pull request
Jul 13, 2023
Fixes a post commit failure after #10282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the emit the Native CPU subhandler as LLVM-IR, instead of emitting its declaration as C++ code in the Native CPU integration header. This is a first step towards removing the Native CPU integration header, using clang-offload-wrapper and also supporting multiple SYCL targets alongside SYCL Native CPU, which we will implement in following PRs.