Skip to content

[SYCL] Fix sporadic auto_flush lit tests fail #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

idubinov
Copy link
Contributor

Signed-off-by: Igor Dubinov igor.dubinov@intel.com

Signed-off-by: Igor Dubinov <igor.dubinov@intel.com>
Copy link
Contributor

@romanovvlad romanovvlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader
Copy link
Contributor

bader commented Feb 26, 2020

@idubinov, please, ignore https://github.com/intel/llvm/pull/1195/checks?check_run_id=469625707 failure. It's not caused by your change.

@againull againull self-requested a review February 26, 2020 17:30
@romanovvlad romanovvlad merged commit e94cbd3 into intel:sycl Feb 27, 2020
vmaksimo pushed a commit to vmaksimo/llvm that referenced this pull request Feb 14, 2022
This has been addressed in commit 4ccb1b29 ("Add convergent attribute
during reverse translation of OpControlBarrier (intel#1195)", 2021-09-06).

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@6fec8b9
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Feb 23, 2023
With the removal of the host device a selection of in-tree LIT tests
can potentially fail as they rely on a device being available on the
system. intel#6683 removes these tests, but
since most are still valid this commit migrates these to the test-suite.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants