[CI] Fix obtaining the diff for the pull request #1197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New commands will fetch 3 commits: merge commit and two parent commits with the state of the target branch and PR branch. Signed-off-by: Alexey Bader <alexey.bader@intel.com>
|
|
||
| - name: Get clang-format first | ||
| run: sudo apt-get install -yqq clang-format-9 | ||
|
|
||
| - name: Run clang-format for the patch | ||
| run: | | ||
| git diff -U0 --no-color origin/${{github.base_ref}}...HEAD | ./clang/tools/clang-format/clang-format-diff.py -p1 -binary clang-format-9 > ./clang-format.patch | ||
| git diff -U0 --no-color ${GITHUB_SHA}^1 ${GITHUB_SHA} -- | ./clang/tools/clang-format/clang-format-diff.py -p1 -binary clang-format-9 > ./clang-format.patch |
There was a problem hiding this comment.
Am I right that this check now processes diff between the last commit in PR and one commit before? What if PR initially contains more than 1 commit?
There was a problem hiding this comment.
GITHUB_SHA - merge commit for git merge <target branch> <PR branch>.
alexbatashev
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New commands will fetch 3 commits: merge commit and two parent commits
with the state of the target branch and PR branch.
Signed-off-by: Alexey Bader alexey.bader@intel.com