[SYCL][ESIMD] Add on-device tests. #2222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmc-rep, @kychendev, @pratikashar - FYI |
kbobrovs
force-pushed
the
kbobrovs-sycl
branch
2 times, most recently
from
3a2b3c2 to
6d564ac
Compare
vladimirlaz
suggested changes
Jul 31, 2020
| @@ -166,6 +166,10 @@ def getDeviceCount(device_type): | |||
| if platform.system() == "Linux": | |||
| gpu_run_on_linux_substitute = "env SYCL_DEVICE_TYPE=GPU SYCL_BE={SYCL_BE} ".format(SYCL_BE=backend) | |||
| gpu_check_on_linux_substitute = "| FileCheck %s" | |||
| # ESIMD-specific setup. Requires OpenCL for now. | |||
There was a problem hiding this comment.
It is better to check that opencl feature is present as it is requirement
There was a problem hiding this comment.
For now I want the tests to fail when OpenCL feature is not present on GPU, and be able to SYCL_BE=PI_OPENCL
Comment on lines
14
to
39
| class ESIMDSelector : public device_selector { | ||
| // Require GPU device unless HOST is requested in SYCL_DEVICE_TYPE env | ||
| virtual int operator()(const device &device) const { | ||
| if (const char *dev_type = getenv("SYCL_DEVICE_TYPE")) { | ||
| if (!strcmp(dev_type, "GPU")) | ||
| return device.is_gpu() ? 1000 : -1; | ||
| if (!strcmp(dev_type, "HOST")) | ||
| return device.is_host() ? 1000 : -1; | ||
| std::cerr << "Supported 'SYCL_DEVICE_TYPE' env var values are 'GPU' and " | ||
| "'HOST', '" | ||
| << dev_type << "' is not.\n"; | ||
| return -1; | ||
| } | ||
| // If "SYCL_DEVICE_TYPE" not defined, only allow gpu device | ||
| return device.is_gpu() ? 1000 : -1; | ||
| } | ||
| }; | ||
|
|
||
| auto exception_handler = [](exception_list l) { | ||
| for (auto ep : l) { | ||
| try { | ||
| std::rethrow_exception(ep); | ||
| } catch (cl::sycl::exception &e0) { | ||
| std::cout << "sycl::exception: " << e0.what() << std::endl; | ||
| } catch (std::exception &e) { | ||
| std::cout << "std::exception: " << e.what() << std::endl; |
There was a problem hiding this comment.
Common part can be moved to single header to avoid code duplication
Add ESIMD tests which can run on Intel GPU devices. Authors: Gang Chen <gang.y.chen@intel.com> Kaiyu Chen <kai.yu.chen@intel.com> Pratik Ashar <pratik.j.ashar@intel.com> Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com> Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
kbobrovs
force-pushed
the
kbobrovs-sycl
branch
2 times, most recently
from
e9af482 to
a5e2ac3
Compare
Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
vladimirlaz
suggested changes
Aug 2, 2020
Signed-off-by: Konstantin S Bobrovsky <konstantin.s.bobrovsky@intel.com>
vladimirlaz
approved these changes
Aug 3, 2020
|
@bader - can you please take a look and merge if you are OK. |
jsji
pushed a commit
that referenced
this pull request
Nov 24, 2023
This fixes #1728 Original commit: KhronosGroup/SPIRV-LLVM-Translator@dd1f598
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Enable -flto and -fsanitize=cfi in clang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ESIMD tests which can run on Intel GPU devices.
Authors:
Gang Chen gang.y.chen@intel.com
Kaiyu Chen kai.yu.chen@intel.com
Pratik Ashar pratik.j.ashar@intel.com
Konstantin S Bobrovsky konstantin.s.bobrovsky@intel.com
Signed-off-by: Konstantin S Bobrovsky konstantin.s.bobrovsky@intel.com