[Driver] Let all offload builders add inputs to host link job action #2919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a problem with loosing OpenMP device binary when program uses both OpenMP and SYCL offloading models. Signed-off-by: Sergey Dmitriev <serguei.n.dmitriev@intel.com>
AGindinson
previously approved these changes
Dec 21, 2020
There was a problem hiding this comment.
LGTM, though it would be preferable to have @mdtoguchi's approval here as well.
Speaking hypothetically, some kind of an E2E test for SYCL + OpenMP would be desired at some point (not necessarily within this PR). Is this a test case that's been checked to work locally?
Signed-off-by: Sergey Dmitriev <serguei.n.dmitriev@intel.com>
Frankly I have not tried it, but it won't work without this fix anyway. |
AGindinson
approved these changes
Dec 21, 2020
|
Interesting. Is it possible to use OpenMP + SYCL on device in the same program? And in the same TU? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a problem with loosing OpenMP device binary when
program uses both OpenMP and SYCL offloading models.
Signed-off-by: Sergey Dmitriev serguei.n.dmitriev@intel.com