[SYCL] Link only needed symbols from fat static libraries on device side #2970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch changes SYCL linking to link only needed symbols from unbundled fat static libraries instead of linking whole device archive. This is the last change in the series of patches for improving offload linking process. Signed-off-by: Sergey Dmitriev <serguei.n.dmitriev@intel.com>
sndmitriev
requested review from
romanovvlad,
kbobrovs,
AGindinson,
jinge90 and
mdtoguchi
AGindinson
reviewed
Dec 30, 2020
Co-authored-by: Artem Gindinson <artem.gindinson@intel.com>
AGindinson
previously approved these changes
Dec 30, 2020
clang/lib/Driver/ToolChains/SYCL.cpp
Outdated
Comment on lines
152
to
165
| auto AddLinkCommand = [this, &C, &JA, Exec](const char *Output, | ||
| const ArgStringList &Inputs, | ||
| const ArgStringList &Options) { | ||
| ArgStringList CmdArgs; | ||
| copy(Options, std::back_inserter(CmdArgs)); | ||
| copy(Inputs, std::back_inserter(CmdArgs)); | ||
| CmdArgs.push_back("-o"); | ||
| CmdArgs.push_back(Output); | ||
| // TODO: temporary workaround for a problem with warnings reported by | ||
| // llvm-link when driver links LLVM modules with empty modules | ||
| CmdArgs.push_back("--suppress-warnings"); | ||
| C.addCommand(std::make_unique<Command>( | ||
| JA, *this, ResponseFileSupport::AtFileUTF8(), Exec, CmdArgs, None)); | ||
| }; |
There was a problem hiding this comment.
Nit & optional: the lambda could be made more concise if refactored to return CmdArgs - Compilation::addCommand() could be called at the main function's scope with the lambda call passed as a corresponding argument. This should avoid extra copying & allow reducing the closure fields' number (to 0, basically).
Signed-off-by: Sergey Dmitriev <serguei.n.dmitriev@intel.com>
AGindinson
approved these changes
Dec 30, 2020
mdtoguchi
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes SYCL linking to link only needed symbols from unbundled
fat static libraries instead of linking whole device archive. This is the
last change in the series of patches for improving offload linking process.
Signed-off-by: Sergey Dmitriev serguei.n.dmitriev@intel.com