Skip to content

Add a new owner for libdevice to CODEOWNERS #3319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

romanovvlad
Copy link
Contributor

No description provided.

@romanovvlad romanovvlad requested review from jinge90 and pvchupin March 8, 2021 11:22
@romanovvlad romanovvlad requested a review from bader as a code owner March 8, 2021 11:22
@pvchupin
Copy link
Contributor

pvchupin commented Mar 8, 2021

@cperkinsintel, any ideas why Sampler/unnormalized-none-linear.cpp is failing?

@cperkinsintel
Copy link
Contributor

cperkinsintel commented Mar 8, 2021

@cperkinsintel, any ideas why Sampler/unnormalized-none-linear.cpp is failing?

@pvchupin ,
No, I'm not sure why it would fail. I checked that test, and while it is XFAIL for CPU and CUDA devices, it should pass on LevelZero and Windows. I just logged into my Win dev machine to double check it, and it passes there fine, further it had to pass on the CI system before it could be merged into llvm-test-suite. I'll see what else I can find.

It's failing on the very last output of that test. I cannot reproduce the failure. However, I had already made a comment in the test itself about that very line, that interpolation at that position seems possibly incorrect. And there is a discussion with the OpenCL folk on some of the outstanding tickets about the pixel data requirements when using linear interpolation. So, for the moment, I'm going to push a PR to the test that removes that last output check. And I may soon be updating all the linear interpolation lit tests.

@pvchupin
Copy link
Contributor

pvchupin commented Mar 8, 2021

Thanks @cperkinsintel.

@pvchupin pvchupin merged commit a323be4 into intel:sycl Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants