[SYCL] Fix unqiue_ptr out-of-memory checks in scheduler #4592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Select places in the scheduler incorrectly assumes a unique pointer to be null when explicit allocations passed as parameter fails due to the host being out of memory. These changes correct these through the use of std::make_unique. Additionally, Scheduler::GraphBuilder::connectDepEvent assumed the same for a raw pointer, whilst not checking the creation of its constituent unique pointers. Allocation here is now governed by a catch of `std::bad_alloc`. Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
romanovvlad
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select places in the scheduler incorrectly assumes a unique pointer to be null when explicit allocations passed as parameter fails due to the host being out of memory. These changes correct these assumptions through the use of std::make_unique.
Additionally, Scheduler::GraphBuilder::connectDepEvent assumed the same for a raw pointer, whilst not checking the creation of its constituent unique pointers. Allocation here is now governed by a catch of
std::bad_alloc.