[NFC][SYCL] Switch to std:: equivalents for utilities in stl_type_traits.hpp #9162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarnex
approved these changes
Apr 21, 2023
| @@ -70,7 +70,7 @@ constexpr unsigned int ElemsPerAddrEncoding() { | |||
| else if constexpr (ElemsPerAddr == 4) | |||
| return 2; | |||
|
|
|||
| // other cases not needed since enable_if disallows other values | |||
| // other cases not needed since std::enable_if disallows other values | |||
| @@ -849,7 +849,7 @@ line(float P, float Q, __ESIMD_NS::simd<T, SZ> src1, Sat sat = {}) { | |||
| // The only input and return types for these APIs are floats. | |||
| // In order to be able to use the old emu code, we keep the template argument | |||
| // for the type, although the type "T" can only be float. | |||
| // We use enable_if to force the float type only. | |||
| // We use std::enable_if to force the float type only. | |||
| @@ -1118,7 +1118,7 @@ __ESIMD_API __ESIMD_NS::simd<float, SZ> lrp(__ESIMD_NS::simd<float, SZ> src0, | |||
| // The only input and return types for these APIs are floats. | |||
| // In order to be able to use the old emu code, we keep the template argument | |||
| // for the type, although the type "T" can only be float. | |||
| // We use enable_if to force the float type only. | |||
| // We use std::enable_if to force the float type only. | |||
|
Thanks for the quick review! I noticed those as well, but I think it makes sense to keep the changes. |
|
ok sounds good, no strong opinion |
aelovikov-intel
force-pushed
the
use-std
branch
from
f2aa008 to
37bce59
Compare
|
I know that review has already started, but I think rebase for this kind of PR is slightly better than merge. |
…its.hpp Re-commits intel#7628 and intel#7668 that were previously reverted due to build issues on RHEL systems. The issues were fixed by introducing `SYCL_LIBDEVICE_GCC_TOOLCHAIN` cmake configuration option in intel#7771.
aelovikov-intel
force-pushed
the
use-std
branch
from
37bce59 to
8d1f841
Compare
bso-intel
approved these changes
Apr 21, 2023
v-klochkov
approved these changes
Apr 21, 2023
|
CUDA failure on "STOP AWS" task is just a cleanup and doesn't perform any checks, so no need to wait for it. @intel/llvm-gatekeepers , this PR is ready. |
Pennycook
added a commit
to Pennycook/llvm
that referenced
this pull request
Apr 24, 2023
Required after intel#9162.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-commits #7628 and #7668 that were previously reverted due to build issues on RHEL systems. The issues were fixed by introducing
SYCL_LIBDEVICE_GCC_TOOLCHAINcmake configuration option in #7771.