Skip to content

real fix for sass #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/site-menu/site-menu-map.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export default {
'Theming': {
'Basics': '/docs/theming/basics',
'Theming with CSS': '/docs/theming/theming-with-css',
'Theming with Scss': '/docs/theming/theming-with-scss'
'Theming with Sass': '/docs/theming/theming-with-sass'
},
'Contributing': {},
'FAQ': {}
Expand Down
2 changes: 1 addition & 1 deletion src/docs-content/theming/basics.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Theming Basics
Ionic components can be themed at runtime using CSS properties. For more advanced theming, check out the **Theming with Scss** section of this guide. For a more in depth look at CSS theming, head over to the **Theming with CSS** section. To change the look of your application you can simply set any CSS properties you would like to change. Currently, Ionic's runtime theming is restricted to color changes. For layout changes you will need to dive into Scss theming. To begin, lets talk about the basic color concepts.
Ionic components can be themed at runtime using CSS properties. For more advanced theming, check out the **Theming with Sass** section of this guide. For a more in depth look at CSS theming, head over to the **Theming with CSS** section. To change the look of your application you can simply set any CSS properties you would like to change. Currently, Ionic's runtime theming is restricted to color changes. For layout changes you will need to dive into Sass theming. To begin, lets talk about the basic color concepts.

#### The Color Map
```
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Theming with Scss
SASS based theming allows for total control over the CSS generated for all of the Ionic Components; however, this requires a build step. CSS generated will still have CSS properties in them and it is recommended that these variables are not changed to allow your applications to use other themes easily. However, in the case of a completely custom application that requires no runtime theming, all the SASS is available for customization.
# Theming with Sass
Sass based theming allows for total control over the CSS generated for all of the Ionic Components; however, this requires a build step. CSS generated will still have CSS properties in them and it is recommended that these variables are not changed to allow your applications to use other themes easily. However, in the case of a completely custom application that requires no runtime theming, all the Sass is available for customization.

## Colors
SASS variable theming concepts are very similar to that of CSS properties. In its simplest form, a custom theme can be generated by changing colors in the color map. Since most components use the primary color, this is the fastest way to get a custom look.
Sass variable theming concepts are very similar to that of CSS properties. In its simplest form, a custom theme can be generated by changing colors in the color map. Since most components use the primary color, this is the fastest way to get a custom look.

```sass
$colors: (
Expand Down