Skip to content

AGNKNCS-1: add ability to update and create select attributes #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ag0n1k
Copy link
Contributor

@ag0n1k ag0n1k commented Jan 5, 2021

Stuck with the same issue described here:
#51

Found the PR here:
#187

But, it's not ready for a merge, and just copy-paste without any warranty of working code. Here are some better code, that were tested against scenarios:

from notion.client import NotionClient

DB_LINK = "https://www.notion.so/ag0n1k/bc8849d1e1bc495e85be23f3e0079ad7?v=441798ba657d43ac82a46d95e0dce81a"
TOKEN_V2 = "TOKEN"

client = NotionClient(token_v2=TOKEN_V2)
cv = client.get_collection_view(DB_LINK)
row = cv.collection.add_row()

row.select = "test5"
row.tags = "erst"
row.tags = ["erst2","123"]
row.tags = ["test1","123"]
row.tags = ["test1","test1","123","test2","123"]

@ag0n1k
Copy link
Contributor Author

ag0n1k commented Jan 16, 2021

@jamalex Hi! Is this project still alive?

@jamalex
Copy link
Owner

jamalex commented Jan 25, 2021

Thanks, this looks like a good approach, and clear code!

I'm going to merge and test it out, and add some tests for it in the smoke testing file.

Is this project still alive?

Is a sloth alive? :)

@jamalex jamalex merged commit 3c23b61 into jamalex:master Jan 25, 2021
@jamalex
Copy link
Owner

jamalex commented Jan 25, 2021

Added my tweaks and tests here: 9b91edf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants