Skip to content

Add info ℹ️ and debug 🐛topics #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wojtkowiak
Copy link

Hey,

would you consider adding this?
It would be better to pass the topics to Logger constructor. I wanted to do a PR for it, but realized that I need to somehow pass it to studio-log-format and I am not sure what would be the correct way.

@mantoni
Copy link
Member

mantoni commented Oct 16, 2018

Thanks for the pull request. I’m not against adding topics. However, the emoji for debug is already used for issue.

The other thing is that I‘d prefer to only have topics that say something about what is being logged. The typical info and debug levels are pretty neutral and can be used for anything. This is fine for loggers with severity levels to enable or disable logs for a specific level. This is explicitly avoided by design in this logger implementation.

Again, if you have some other topics that you‘d like to have, I‘m happy to merge a PR.

@wojtkowiak
Copy link
Author

Ok, I agree. I can use issue for debug things and yeah info pretty much can be anything. So that's fine.
I will definitely need to add some more topics as the project grows, so maybe if you have moment it would be good to think about a way of adding topics through configuration. Like I said I already did that for the logger but when I have node j.js | emojilog there is no way passing that further to emojilog or at least a non-hacky way.

@mantoni
Copy link
Member

mantoni commented Oct 19, 2018

I think making topics configurable might cause quite some inconveniences when using the logger, especially when invoking emojilog. You would have to introduce a way to specify a configuration file and always pass it on invocation.

If you’re willing to go down that road, I‘ll support you. Alternatively we can add more topics here. I’m happy to merge pull requests with additional topics here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants