Skip to content

Automated cherry pick of #132109: Clean backoff record earlier #132159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-1.32
Choose a base branch
from
Open

Automated cherry pick of #132109: Clean backoff record earlier #132159

wants to merge 1 commit into from
+103 −0

Conversation

linxiulei
Copy link
Contributor

Cherry pick of #132109 on release-1.32.

#132109: Clean backoff record earlier

For details on the cherry pick process, see the cherry pick requests page.

Fix a bug causing unexpected delay of creating pods for newly created jobs

@linxiulei @mimowo
Clean backoff record earlier
62eb11d 
Once received job deletion event, it cleans the backoff records for that
job before enqueueing this job so that we can avoid a race condition
that the syncJob() may incorrect use stale backoff records for a newly created
job with same key.

Co-authored-by: Michal Wozniak <michalwozniak@google.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Jun 6, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 6, 2025
@k8s-ci-robot
Copy link
Contributor

This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

If you didn't cherry-pick this change to all supported release branches, please leave a comment describing why other cherry-picks are not needed to speed up the review process.

If you're not sure is it required to cherry-pick this change to all supported release branches, please consult the cherry-pick guidelines document.

AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers

(This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)

For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 6, 2025
@k8s-ci-robot k8s-ci-robot requested review from kow3ns and krmayankk June 6, 2025 20:51
@k8s-ci-robot k8s-ci-robot added area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 6, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Jun 6, 2025
@linxiulei
Copy link
Contributor Author

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team June 6, 2025 21:00
@mimowo
Copy link
Contributor

mimowo commented Jun 6, 2025 •
edited
Loading

/lgtm
/approve
As a Job maintainer.

For justification see comment.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 495007d2c09a6eb2b9e8f00c66342bf2813a1237

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: linxiulei, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2025
@mimowo
Copy link
Contributor

mimowo commented Jun 6, 2025

/test pull-kubernetes-unit
This is infra flake: There are no nodes that your pod can schedule to - check your requests, tolerations, and node selectors (0/92 nodes are available: 11 node(s) had untolerated taint {node.kubernetes.io/not-ready: }, 19 Insufficient memory, 3 node(s) had untolerated taint {dedicated: sig-node}, 70 Insufficient cpu, 8 node(s) had untolerated taint {kubernetes.io/arch: arm64}. preemption: 0/92 nodes are available: 22 Preemption is not helpful for scheduling, 70 No preemption victims found for incoming pod.)

@linxiulei
Copy link
Contributor Author

/retest

@atiratree
Copy link
Member

/kind bug
/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kow3ns kow3ns Awaiting requested review from kow3ns

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees

@mimowo mimowo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Status: Needs Triage
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
4 participants
@linxiulei @k8s-ci-robot @mimowo @atiratree