Skip to content

Update to match rdkafka version 6.0.4 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bdurkovic
Copy link

  • Added methods added in rdkafka 6.0.4
  • Kept compatibility with php 7.x to match composer requirement in rdkafka 6.x
  • Added parameters and return types where possible
  • Added callback parameters in phpdoc

@bdurkovic
Copy link
Author

@kwn no pressure, but any chance you could take a look at this? Is there anything else I could do to make this happen?

@kwn
Copy link
Owner

kwn commented May 2, 2025

Hi @bdurkovic
Thank you for your contribution. At the moment I have almost no spare time due to some personal matters, but please give me a bit more time, and I'll look into the PR in the upcoming weeks. Thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants