Skip to content

Copy announcement message addresses into NodeInfo on load #1630

Closed
@TheBlueMatt

Description

@TheBlueMatt

On startup, we may deserialize a stored NodeAnnouncement and find new address types that we previously didn't understand. This will leave us with a NodeInfo struct (the obvious place users will look for address information) that has an addresses list that is missing elements.

Additionally, we're storing address information twice in two separate, redundant, heap-allocated structures.

We should address both issues by simply dropping the address list from NodeInfo. The only two gotchas are that we'll want to provide serialization compatibility, and that we'll want to ensure we're liberal in storing NodeAnnouncements as long as they have even a mostly-reasonable excess data size. We should probably take this opportunity to also relay NodeAnnouncments that have more excess data than zero.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions