0.0.105 Security Fixes #1339
Merged
0.0.105 Security Fixes #1339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we added support for routing through a multi-hop invoice hint we failed to remove an assertion that we always are able to fill in features for each hop except the last one. However, when a multi-hop invoice hint is used, we will not have features for any of the hinted hops, causing us to panic.
This doesn't (appear) to change behavior, however if we have a non-public node, we assign an A* heuristic of max-u32 fees, which may result in us de-prioritizing the path in some rare cases around multi-hop route hints which compete with public nodes.
When handling the broadcast of a local commitment transactions (with associated CSV delays prior to spendability), we incorrectly handled the CSV delays on HTLC transactions. This caused us to miss spendable outputs for HTLCs which were awaiting a CSV delay. Further, because of this, we could hit an assertion as `get_claimable_balances` asserted that HTLCs were resolved after the funding spend was resolved, which was not true if the HTLC did not have a CSV delay attached (due to the above bug or due to it being an HTLC claim by our counterparty). This fixes both bugs, also converting some assertions to `debug_assert`s to avoid future issues as balance mis-calculation is not currently an indication of potential funds loss. Thanks to Cash App for reporting this bug.
... by calling it both before and after every chain event in testing and fuzzing. This requires fixing some blockchain inconsistencies in `do_test_onchain_htlc_reorg`, `do_retry_with_no_persist`, and `do_test_dup_htlc_onchain_fails_on_reload` where we'd connect conflicting transactions in the same chain.
jkczyz
approved these changes
Mar 1, 2022
valentinewallace
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two PRs fixing two DoS issues, built on #1322. Both were previously reviewed elsewhere.