Skip to content

wasm: update HasPermissions to account for custom perms #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

ellemouton
Copy link
Member

@ellemouton ellemouton commented Oct 25, 2022

This commit updates the HasPermissions function to account for the case where the session has custom permissions which would specify "uri" as the permission entity and the actual URI as the permission action.

works with lightninglabs/lightning-terminal#438

Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ellemouton ellemouton requested review from itsrachelfish and removed request for jamaljsr October 25, 2022 16:14
This commit updates the HasPermissions function to account for the case
where the session has custom permissions which would specify "uri" as
the permission entity and the actual URI as the permission action.
@ellemouton ellemouton merged commit 73f0035 into lightninglabs:master Oct 27, 2022
@ellemouton ellemouton deleted the customSessions branch October 27, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants