Skip to content

itest: export HashmailHarness struct #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 14, 2023
Merged

itest: export HashmailHarness struct #76

merged 3 commits into from
Jun 14, 2023

Conversation

ViktorTigerstrom
Copy link
Contributor

This PR exports the HashmailHarness struct, so that it can be used as an external dependency to setup a local mail server.

@ellemouton
Copy link
Member

looks like we should maybe update the linter config. Linters like exhaustivestruct have been deprecated :)

@ViktorTigerstrom
Copy link
Contributor Author

ViktorTigerstrom commented May 31, 2023 •
edited
Loading

looks like we should maybe update the linter config. Linters like exhaustivestruct have been deprecated :)

Ok thanks, was a bit confused about what's happening with the CI! I will look into that @ellemouton!

@ViktorTigerstrom ViktorTigerstrom force-pushed the 2023-05-export-hashmail-harness branch 5 times, most recently from 66c59d5 to e801daf Compare June 1, 2023 14:27
@ViktorTigerstrom
Copy link
Contributor Author

Ok finally got the linter to work properly :)! I updated the config to use a similar config to LND, as I figured it's likely our most up to date linter configs.

I pushed the update linter settings as 2 separate commits to this PR. Let me know if you think it's better that I push them as a separate PR instead @ellemouton!

ellemouton
ellemouton approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) one nit :)

@ViktorTigerstrom ViktorTigerstrom force-pushed the 2023-05-export-hashmail-harness branch 2 times, most recently from 951a16a to 66ce69b Compare June 1, 2023 21:07
@ViktorTigerstrom
Copy link
Contributor Author

Thanks for the review and the feedback @ellemouton! Addressed it with the latest push :)

@lightninglabs-deploy
Copy link

@bitromortac: review reminder

bitromortac
bitromortac approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@bitromortac bitromortac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍, sorry for the late review

@ViktorTigerstrom
Copy link
Contributor Author

Thanks for the review @bitromortac!

@ellemouton
Copy link
Member

@ViktorTigerstrom - the LNC repo prevents me from merging if the commits are not signed (see the "Merging is blocked" warning above)

@ViktorTigerstrom
itest: export HashmailHarness struct
642c536
@ViktorTigerstrom
linter: Update linter config
829ba29 
Remove deprecated linters and add working setting for previously
excluded linters.
@ViktorTigerstrom
itest: adjust code according to linters
85f5f04
@ViktorTigerstrom ViktorTigerstrom force-pushed the 2023-05-export-hashmail-harness branch from 66ce69b to 85f5f04 Compare June 14, 2023 09:13
@ViktorTigerstrom
Copy link
Contributor Author

ViktorTigerstrom commented Jun 14, 2023 •
edited
Loading

Updated the commits' author to my GPG key email address & signed the commits.

@ellemouton ellemouton merged commit a4a8bd6 into lightninglabs:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellemouton ellemouton ellemouton approved these changes

@bitromortac bitromortac bitromortac approved these changes

Assignees

@ViktorTigerstrom ViktorTigerstrom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ViktorTigerstrom @ellemouton @lightninglabs-deploy @bitromortac