Skip to content

wasm-client: bump lightning terminal #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ViktorTigerstrom
Copy link
Contributor

This PR bumps the lightning-terminal version for the wasm-client.
We also add new features of that's been added to the lightning-terminal dependency since v0.10.X-alpha. Mainly subserver permissions have been added, and the inclusion of the taproot-assets cli, which we've added support for in the LNC WASM client example.

This PR currently uses a forked version on lightning-terminal, until a PR with the required change to the litclient Registrations have been merged.

Happy to address any feedback :)!

@ellemouton
Copy link
Member

nice one @ViktorTigerstrom ! Can you open the other dependent PRs pls? the taro & lit one?

@ViktorTigerstrom
Copy link
Contributor Author

The taproot-assets PR wasn't needed actually, but will open the lightning-terminal one @ellemouton!

Copy link
Member

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK LGTM 🚀

@ViktorTigerstrom ViktorTigerstrom force-pushed the 2023-06-bump-lightning-terminal branch 6 times, most recently from 43c06a8 to a6b2826 Compare June 12, 2023 11:37
ViktorTigerstrom and others added 4 commits June 12, 2023 13:37
Bump lightning-terminal to version v0.10.1-alpha. Since we also
specifically like to include a fix that was merged in the master branch
of lightning-terminal after the v0.10.1-alpha release, we bump the
version to the commit of the master branch that includes that fix
(v0.10.1-alpha.0.20230612093826-ee04747e4a34). This fix is required in
order to be able to add taproot-assets support for the WASM client.

Also update lnd to version v0.16.3-beta and grpc to version v1.45.0, as
it's required with the lightning-terminal bump.
Remove the direct dependency on github.com/golang/protobuf and use
google.golang.org/protobuf for the WASM client instead, as the former is
deprecated.
@ViktorTigerstrom ViktorTigerstrom force-pushed the 2023-06-bump-lightning-terminal branch from a6b2826 to 5aa8730 Compare June 12, 2023 11:38
@ViktorTigerstrom
Copy link
Contributor Author

ViktorTigerstrom commented Jun 12, 2023

Updated the PR to use the latest version of the lightning-terminal master branch now that the the required taproot-assets fix has been merged 🚀!

I also included a commit aac8c84 that replaces the protobuf dependency with
the google.golang.org version, as I got warnings that the old version was deprecated.
I didn't replace it with our own forked version though (github.com/lightninglabs/protobuf-go-hex-display), as it currently isn't required to make the WASM client function.
If you think I should fixup this commit with the first mod commit, or that I should use our own forked version, let me know and I'll fix that :)!

@ellemouton
Copy link
Member

nice! I think you can keep the commit that removes the deprecated version :) and no I dont think we need replace it with protobuf-go-hex-display if it is not yet used here

Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, LGTM! 🚀

@ellemouton ellemouton merged commit b0ee139 into lightninglabs:master Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants