-
Notifications
You must be signed in to change notification settings - Fork 22
wasm-client: bump lightning terminal #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm-client: bump lightning terminal #77
Conversation
nice one @ViktorTigerstrom ! Can you open the other dependent PRs pls? the taro & lit one? |
The taproot-assets PR wasn't needed actually, but will open the lightning-terminal one @ellemouton! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK LGTM 🚀
43c06a8
to
a6b2826
Compare
Bump lightning-terminal to version v0.10.1-alpha. Since we also specifically like to include a fix that was merged in the master branch of lightning-terminal after the v0.10.1-alpha release, we bump the version to the commit of the master branch that includes that fix (v0.10.1-alpha.0.20230612093826-ee04747e4a34). This fix is required in order to be able to add taproot-assets support for the WASM client. Also update lnd to version v0.16.3-beta and grpc to version v1.45.0, as it's required with the lightning-terminal bump.
Remove the direct dependency on github.com/golang/protobuf and use google.golang.org/protobuf for the WASM client instead, as the former is deprecated.
a6b2826
to
5aa8730
Compare
Updated the PR to use the latest version of the I also included a commit aac8c84 that replaces the |
nice! I think you can keep the commit that removes the deprecated version :) and no I dont think we need replace it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK, LGTM! 🚀
This PR bumps the lightning-terminal version for the wasm-client.
We also add new features of that's been added to the lightning-terminal dependency since v0.10.X-alpha. Mainly subserver permissions have been added, and the inclusion of the taproot-assets cli, which we've added support for in the LNC WASM client example.
This PR currently uses a forked version on lightning-terminal, until a PR with the required change to the litclient Registrations have been merged.
Happy to address any feedback :)!