multi: add support for building without UI #500
Conversation
terminal.go
Outdated
| // +--------------------------+ | - faraday | | ||
| // | - loop | | ||
| // | - pool | | ||
| // +---------------------+ |
There was a problem hiding this comment.
mh weird formatting change, I'm running go1.20.1
There was a problem hiding this comment.
Yeah, that's the new comment formatter that was added with 1.18 or 1.19, so kind of expected.
app.go
Outdated
| @@ -0,0 +1,19 @@ | |||
| //go:build !no_ui | |||
There was a problem hiding this comment.
I wonder if instead of adding this build tag, more or less the same couldn't be achieved by just adding a mkdir -p app/build && touch app/build/index.html command to the go-build-noui?
There was a problem hiding this comment.
Going with the tag has the advantage of being able to build litd purely with go build whereas the approach you suggested needs additional shell commands.
|
Could you please rebase and make it ready for review @sputn1ck ? |
This commit adds support for building without UI. If the build tag "litd no_ui" is set the UI will be disabled.
Yes please, could you add to 0-19-staging? |
Done: 4f1dde8 |
This commit adds support for building without UI. If the build tag "no_ui" is set the UI will be disabled and an empty
embed.FSwill be served. I'm successfully running it on my nix-bitcoin node with the following nix-bitcoin pkgs/modules sputn1ck/nix-bitcoin@d69e557NOTE: this doesn't remove the need for an
uipassword