litclient: add taprpc packages to Registrations
#816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guggero
approved these changes
Aug 9, 2024
Add the `priceoraclerpc`, `rfqrpc`, and the `tapchannelrpc` JSON callbacks to the litclient's `Registrations` array. This allows the litclient to use the rpc functions contained in these JSON callbacks.
jamaljsr
force-pushed
the
tap-rpc-registrations
branch
from
0fccf87 to
0922af1
Compare
|
Rebased on the latest |
GeorgeTsagk
approved these changes
Aug 9, 2024
ellemouton
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
priceoraclerpc,rfqrpc, and thetapchannelrpcJSON callbacks to the litclient'sRegistrationsarray. This allows the litclient to use the rpc functions contained in these JSON callbacks.These registrations are required for apps using the LNC (wasm) to call RPC methods. Without these additional callbacks, the wasm will return a "RPC method not found" error when calling RPCs contained in these packages.