Skip to content

test: refactor asserts #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2023
Merged

test: refactor asserts #1949

merged 1 commit into from
Oct 26, 2023

Conversation

alexandear
Copy link
Member

This PR refactors tests by replacing if err != nil with assert.NilError(t, err).

@alexandear
test: refactor asserts
c3426a5 
Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>
@alexandear alexandear force-pushed the refactor-test-asserts branch from 491cfd7 to c3426a5 Compare October 25, 2023 14:13
@AkihiroSuda AkihiroSuda added this to the v1.0 (tentative) milestone Oct 26, 2023
@AkihiroSuda AkihiroSuda added area/test Tests and CI kind/refactoring Refactoring labels Oct 26, 2023
AkihiroSuda
AkihiroSuda approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 1c0a3ab into lima-vm:master Oct 26, 2023
@AkihiroSuda AkihiroSuda modified the milestones: v1.0, v0.18.1 Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
area/test Tests and CI kind/refactoring Refactoring
Projects
None yet
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @AkihiroSuda