Skip to content

[HLSL] Fix failing SPIR-V backend tests that specify --target-env vulkan1.3 #136344

@kmpeng

Description

@kmpeng

Problem

When SPIRV-Tools is enabled, tests that specify the target environment vulkan1.3 in the validation step fail. The tests are:

  • CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll (link)
  • CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll (link)

Temporary fix

This PR was a stop gap to get the pipeline green again:
#136343

Long term fix

The current suggestion from @s-perron is to change the tests to not have external functions or variables, e.g. making the functions shader entry points. More discussion is likely needed.

Metadata

Metadata

Assignees

Type

Projects

Status

Closed

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions