clang/lib/Format/Format.cpp:3581: vector copy problem ?

[dcb314]

Static analyser cppcheck says:

clang/lib/Format/Format.cpp:3581:49: performance: Function parameter 'Ranges' should be passed by const reference. [passedByValue]

Source code is

               std::vector<tooling::Range> Ranges,

This might be worth using a constant reference on.

[llvmbot]

@llvm/issue-subscribers-clang-format

Author: None (dcb314)

Static analyser cppcheck says:

clang/lib/Format/Format.cpp:3581:49: performance: Function parameter 'Ranges' should be passed by const reference. [passedByValue]

Source code is

               std::vector<tooling::Range> Ranges,

This might be worth using a constant reference on.

[shafik]

This one is not as obvious, it looks like we are taking a copy when we don't need to.

CC @AaronBallman