Skip to content

[mlir][tensor] Relax input type requirement on tensor.splat #145893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
+29 −11
Merged

[mlir][tensor] Relax input type requirement on tensor.splat #145893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a1cd6d
[mlir][tensor] Relax input type requirement on `tensor.splat`
zero9178 Jun 26, 2025
cd1b786
address review comments
zero9178 Jun 26, 2025
0e4676e
use type legal memref type in bufferization test
zero9178 Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions mlir/include/mlir/Dialect/Tensor/IR/TensorOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1771,8 +1771,7 @@ def Tensor_SplatOp : Tensor_Op<"splat", [
]> {
let summary = "tensor splat or broadcast operation";
let description = [{
Broadcast the operand to all elements of the result tensor. The operand is
required to be of integer/index/float type.
Broadcast the operand to all elements of the result tensor.

An additional argument of type `index` must be provided for each dynamic
dimension present in the result type.
Expand All @@ -1795,8 +1794,7 @@ def Tensor_SplatOp : Tensor_Op<"splat", [
```
}];

let arguments = (ins AnyTypeOf<[AnySignlessInteger, Index, AnyFloat],
"integer/index/float type">:$input,
let arguments = (ins AnyType:$input,
Variadic<Index>:$dynamicSizes);
let results = (outs AnyRankedTensor:$aggregate);

Expand Down
15 changes: 15 additions & 0 deletions mlir/test/Dialect/Tensor/bufferize.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,21 @@ func.func @tensor.splat(%f: f32) -> tensor<10x2x4xf32> {

// -----

// CHECK-LABEL: func @tensor.splat_other(
// CHECK-SAME: %[[F:.*]]: !test.memref_element)
// CHECK-DAG: %[[ALLOC:.*]] = memref.alloc() {{.*}} : memref<10x2x4x!test.memref_element>
// CHECK: %[[ALLOC_T:.*]] = bufferization.to_tensor %[[ALLOC]]
// CHECK: %[[MAPPED:.*]] = linalg.map
// CHECK: outs(%[[ALLOC_T]] : tensor<10x2x4x!test.memref_element>)
// CHECK: linalg.yield %[[F]]
// CHECK: return %[[MAPPED]] : tensor<10x2x4x!test.memref_element>
func.func @tensor.splat_other(%f: !test.memref_element) -> tensor<10x2x4x!test.memref_element> {
%t = tensor.splat %f : tensor<10x2x4x!test.memref_element>
return %t : tensor<10x2x4x!test.memref_element>
}

// -----

// CHECK-LABEL: func @tensor.concat(
// CHECK-SAME: %[[F:.*]]: tensor<8xf32>)
// CHECK: %[[F_MEMREF:.*]] = bufferization.to_buffer %[[F]]
Expand Down
7 changes: 4 additions & 3 deletions mlir/test/Dialect/Tensor/invalid.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,9 +466,10 @@ func.func @invalid_splat(%v : f32) {

// -----

func.func @invalid_splat(%v : vector<8xf32>) {
// expected-error@+1 {{must be integer/index/float type}}
%w = tensor.splat %v : tensor<8xvector<8xf32>>
// expected-note@+1 {{prior use here}}
func.func @invalid_splat(%v : f32) {
// expected-error@+1 {{expects different type than prior uses: 'i32' vs 'f32'}}
%w = tensor.splat %v : tensor<1xi32>
return
}

Expand Down
12 changes: 8 additions & 4 deletions mlir/test/Dialect/Tensor/ops.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,13 +313,17 @@ func.func @pad_to_static_size(%arg0: tensor<?x?xf32>, %ub0: index, %ub1: index,
// -----

// CHECK-LABEL: func @test_splat_op
// CHECK-SAME: [[S:%arg[0-9]+]]: f32
func.func @test_splat_op(%s : f32) {
// CHECK: tensor.splat [[S]] : tensor<8xf32>
// CHECK-SAME: %[[S:.*]]: f32
// CHECK-SAME: %[[P:.*]]: !llvm.ptr
func.func @test_splat_op(%s : f32, %p : !llvm.ptr) {
// CHECK: tensor.splat %[[S]] : tensor<8xf32>
%v = tensor.splat %s : tensor<8xf32>

// CHECK: tensor.splat [[S]] : tensor<4xf32>
// CHECK: tensor.splat %[[S]] : tensor<4xf32>
%u = "tensor.splat"(%s) : (f32) -> tensor<4xf32>

// CHECK: tensor.splat %[[P]] : tensor<8x!llvm.ptr>
%w = tensor.splat %p : tensor<8x!llvm.ptr>
return
}

Expand Down