[lldb/crashlog] Fix test failure when creating a target using command options #91653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… options This should fix the various crashlog test failures. When we create a target by using the command option, we don't set it in the crashlog object which later on cause us to fail loading the images. rdar://127832961 Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>
|
@llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) ChangesThis should fix the various crashlog test failures on the bots: When we create a target by using the command option, we don't set it in the crashlog object which later on cause us to fail loading the images. rdar://127832961 Full diff: https://github.com/llvm/llvm-project/pull/91653.diff 1 Files Affected:
diff --git a/lldb/examples/python/crashlog.py b/lldb/examples/python/crashlog.py
index 2919b9c76e68b..641b2e64d53b1 100755
--- a/lldb/examples/python/crashlog.py
+++ b/lldb/examples/python/crashlog.py
@@ -1494,6 +1494,7 @@ def load_crashlog_in_scripted_process(debugger, crashlog_path, options, result):
raise InteractiveCrashLogException(
"couldn't create target provided by the user (%s)" % options.target_path
)
+ crashlog.target = target
# 2. If the user didn't provide a target, try to create a target using the symbolicator
if not target or not target.IsValid():
|
JDevlieghere
approved these changes
May 9, 2024
bulbazord
approved these changes
May 9, 2024
medismailben
added a commit
to medismailben/llvm-project
that referenced
this pull request
May 14, 2024
… options (llvm#91653) This should fix the various crashlog test failures on the bots: ``` lldb-shell :: ScriptInterpreter/Python/Crashlog/app_specific_backtrace_crashlog.test lldb-shell :: ScriptInterpreter/Python/Crashlog/interactive_crashlog_json.test lldb-shell :: ScriptInterpreter/Python/Crashlog/interactive_crashlog_legacy.test lldb-shell :: ScriptInterpreter/Python/Crashlog/last_exception_backtrace_crashlog.test lldb-shell :: ScriptInterpreter/Python/Crashlog/skipped_status_interactive_crashlog.test ``` When we create a target by using the command option, we don't set it in the crashlog object which later on cause us to fail loading the images. rdar://127832961 Signed-off-by: Med Ismail Bennani <ismail@bennani.ma> (cherry picked from commit db94213)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the various crashlog test failures on the bots:
When we create a target by using the command option, we don't set it in the crashlog object which later on cause us to fail loading the images.
rdar://127832961