Use different WebhookConfiguration name in every webhook e2e test spec #2811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind test
What else do we need to know?
Both WebhookConfigurations created in webhooks e2e tests currently have the same name. This PR changes that so that every created WebhookConfiguration has a different name.
Having different WebhookConfiguration names in each test reduces the chance that the first test's webhook resources interfere with the second test.
Since both webhooks currently have the same name, there is a chance that the first test will interfere with the second one because when the WebhookConfiguration resource is created/deleted, API server needs a bit of time to process the changes and start/stop using the new/deleted WebhookConfiguration, but the webhook test is deleting and creating WebhookConfiguration with the same name in a matter of milliseconds.
From Kubernetes docs: