Skip to content

feat: prompt user to create a personal access token beforehand #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 9, 2019
Merged

feat: prompt user to create a personal access token beforehand #48

merged 5 commits into from
Dec 9, 2019

Conversation

rishabhKalakoti
Copy link
Contributor

@rishabhKalakoti rishabhKalakoti commented Dec 6, 2019

Description

This is a WIP PR.

  • The prompt is positioned to come before the repo needs to be created for a new user. (For existing users of teachcode, it is not needed)
  • Open the GitHub help page for access token creation in the browser.
  • Documentation

Fixes # 23

Type of change

  • New feature

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@welcome
Copy link

welcome bot commented Dec 6, 2019

Thanks for opening this pull request! Please check out our contributing guidelines.

@jamesgeorge007 jamesgeorge007 self-requested a review December 6, 2019 17:16
@jamesgeorge007 jamesgeorge007 added the enhancement New feature or request label Dec 6, 2019
@jamesgeorge007 jamesgeorge007 changed the title [WIP] feat: prompt user to create a personal access token for github cli [WIP] feat: prompt user to create a personal access token beforehand Dec 6, 2019
@ghost
Copy link

ghost commented Dec 6, 2019

There were the following issues with this Pull Request

  • Commit: b11c471
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@rishabhKalakoti rishabhKalakoti changed the title [WIP] feat: prompt user to create a personal access token beforehand feat: prompt user to create a personal access token beforehand Dec 6, 2019
@jamesgeorge007 jamesgeorge007 self-requested a review December 7, 2019 03:47
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like you're missing out on the lock file changes. Rest LGTM 👍

@jamesgeorge007 jamesgeorge007 self-requested a review December 9, 2019 09:25
@jamesgeorge007 jamesgeorge007 merged commit 26f3868 into madlabsinc:next Dec 9, 2019
@welcome
Copy link

welcome bot commented Dec 9, 2019

congrats
Congrats on your very first contribution 👏 Looking forward to having more from your side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants