Skip to content

fix: fetchtask command takes last generated key as the argument by default #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2019

Conversation

sandeepsj
Copy link
Contributor

@sandeepsj sandeepsj commented Dec 13, 2019

Description

To get the next task, the user can either go through the keys to get the latest one and paste it with the fetchtask command, or call fetchtask command along

Fixes # (issue 54)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@sandeepsj sandeepsj changed the title fix: issue 54 , the key is optional for fetchtask now fix: fetchtask command takes last generated key as the argument by default Dec 13, 2019
@jamesgeorge007 jamesgeorge007 self-requested a review December 13, 2019 17:25
@jamesgeorge007 jamesgeorge007 added the enhancement New feature or request label Dec 13, 2019
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far 👏
Just couple of more tweaks and we're good to go 🚀

  • Remove the reference to key here.

" Hurray you've done it!\n Key to access the next task: " +

@jamesgeorge007 jamesgeorge007 self-requested a review December 14, 2019 09:38
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jamesgeorge007 jamesgeorge007 merged commit 3dafd94 into madlabsinc:next Dec 14, 2019
@welcome
Copy link

welcome bot commented Dec 14, 2019

congrats
Congrats on your very first contribution 👏 Looking forward to having more from your side

@jamesgeorge007 jamesgeorge007 added this to the v1.3.0 milestone Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants