[WC-2892]: Calendar improvements #1628
Open
+3,806
−1,291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahmanunver
force-pushed
the
spike/WC-2892-calendar-improvements
branch
from
729563e to
092f468
Compare
gjulivan
reviewed
Jun 20, 2025
| const weekdayList = range.map(d => loc.format(d, "EEE")).join(", "); | ||
|
|
||
| return weekdayList; | ||
| }; |
There was a problem hiding this comment.
can we move out custom week from this function to a separate file?
There was a problem hiding this comment.
note: this custom view extraction will always gets recalculated everytime a simple props changed occurs.
samuelreichert
force-pushed
the
spike/WC-2892-calendar-improvements
branch
from
ee24386 to
dbb7293
Compare
… adjust time building logic
samuelreichert
force-pushed
the
spike/WC-2892-calendar-improvements
branch
from
439a6f9 to
77e1160
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)
Description
Added: