Skip to content

fix(trace): avoid recording BindingCall actions #35851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented May 5, 2025

Some interactions with the Playwright API pass through wrapApiCall but are not actually initiated by the user. Any such calls do not have a generated apiName because there's no non-Playwright code in the stack, thus the action gets recorded in the trace/reports as a completely empty entry. In this case the API being called is a page binding called through the browser.

Screenshot 2025-05-05 at 7 55 35 AM

Do not emit any of these events to the trace.

@agg23 agg23 requested a review from dgozman May 5, 2025 14:57

This comment has been minimized.

@agg23 agg23 changed the title fix(trace): avoid recording actions without apiName fix(trace): avoid recording BindingCall actions May 12, 2025
Copy link
Contributor

Test results for "tests 1"

1 failed
❌ [installation tests] › connect-to-selenium.spec.ts:20:5 › connect to selenium @package-installations-ubuntu-latest

8 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-output.spec.ts:117:5 › should collapse repeated console messages for test @macos-latest-node18-1
⚠️ [chromium-library] › library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake @ubuntu-22.04-chromium-tip-of-tree
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:105:3 › should return bounding box with page scale @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › library/ignorehttpserrors.spec.ts:30:3 › should isolate contexts @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39168 passed, 803 skipped
✔️✔️✔️

Merge workflow run.

@agg23
Copy link
Contributor Author

agg23 commented May 13, 2025

@microsoft-github-policy-service rerun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants