chore: two-line trace view (2) #36055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
May 22, 2025
| } | ||
| { | ||
| const error = await expect(locator).not.toHaveAttribute('checked', /.*/, { timeout: 1000 }).catch(e => e); | ||
| expect(error.message).toContain('expect.not.toHaveAttribute with timeout 1000ms'); | ||
| expect(stripAnsi(error.message)).toContain(`Timed out 1000ms waiting for expect(locator).not.toHaveAttribute(expected)`); | ||
| expect(stripAnsi(error.message)).toContain(`- Expect not toHaveAttribute with timeout 1000ms`); |
There was a problem hiding this comment.
do we actually need stripAnsi here?
| @@ -991,7 +991,7 @@ test('should record nested steps, even after timeout', async ({ runInlineTest }, | |||
| ' fixture: barPage', | |||
| ' barPage teardown', | |||
| ' step in barPage teardown', | |||
| ' page.close', | |||
| ' Close context', | |||
There was a problem hiding this comment.
This should be "Close page", shouldn't it? An in other places too.
|
@microsoft-github-policy-service rerun |
Test results for "tests 1"4 failed 7 flaky39208 passed, 804 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.