Fix more parent races #1031
Merged
Fix more parent races #1031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbranch
requested review from
Copilot,
jakebailey and
gabritto
and removed request for
Copilot
jakebailey
reviewed
Jun 4, 2025
jakebailey
approved these changes
Jun 4, 2025
|
Tests fail, fun |
andrewbranch
force-pushed
the
bug/more-parent-races
branch
from
38a3f90 to
097e4da
Compare
|
The baseline change is actually moving in the right direction—before, module resolution failed completely. Now it succeeds, which reveals another problem that I assume is unrelated to this change. In JSDoc, you’re allowed to refer to values as types (we insert an implicit |
jakebailey
approved these changes
Jun 4, 2025
This was referenced Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#970 was incomplete because I misread
SetParentsInChildrenas not setting the parent if the node already has one.