[WIP] Emitting Declarations for React Components requires type annotation

internal/checker/nodebuilderimpl.go

@@ -18,6 +18,16 @@ import (
 	"github.com/microsoft/typescript-go/internal/tspath"
 )
 
+// isJSXRuntimeImport checks if a specifier is a safe JSX runtime import
+// JSX runtime imports (jsx-runtime and jsx-dev-runtime) are considered safe
+// as they are standard React APIs that should be allowed in declaration files
+func isJSXRuntimeImport(specifier string) bool {
+	return strings.Contains(specifier, "/jsx-runtime") || 
+		   strings.Contains(specifier, "/jsx-dev-runtime") ||
+		   strings.Contains(specifier, "@types/react/jsx-runtime") ||
+		   strings.Contains(specifier, "react/jsx-runtime")
+}
+
 type CompositeSymbolIdentity struct {
 	isConstructorNode bool
 	symbolId          ast.SymbolId
@@ -433,7 +443,7 @@ func (b *nodeBuilderImpl) symbolToTypeNode(symbol *ast.Symbol, mask ast.SymbolFl
 		if len(specifier) == 0 {
 			specifier = b.getSpecifierForModuleSymbol(chain[0], core.ResolutionModeNone)
 		}
-		if (b.ctx.flags&nodebuilder.FlagsAllowNodeModulesRelativePaths == 0) /* && b.ch.compilerOptions.GetModuleResolutionKind() != core.ModuleResolutionKindClassic */ && strings.Contains(specifier, "/node_modules/") {
+		if (b.ctx.flags&nodebuilder.FlagsAllowNodeModulesRelativePaths == 0) /* && b.ch.compilerOptions.GetModuleResolutionKind() != core.ModuleResolutionKindClassic */ && strings.Contains(specifier, "/node_modules/") && !isJSXRuntimeImport(specifier) {
 			oldSpecifier := specifier
 
 			if b.ch.compilerOptions.GetModuleResolutionKind() == core.ModuleResolutionKindNode16 || b.ch.compilerOptions.GetModuleResolutionKind() == core.ModuleResolutionKindNodeNext {

testdata/baselines/reference/compiler/jsxRuntimeDeclarationEmit.js

@@ -0,0 +1,44 @@
+//// [tests/cases/compiler/jsxRuntimeDeclarationEmit.tsx] ////
+
+//// [jsxRuntimeDeclarationEmit.tsx]
+// Test case to reproduce jsx-runtime declaration emit issue
+
+
+/// <reference path="/.lib/react16.d.ts" />
+
+// This should trigger the jsx-runtime import without type annotation error
+
+export const FunctionComponent = () => {
+  return <div>Hello World</div>
+}
+
+export const AnotherComponent = () => {
+  return <FunctionComponent />
+}
+
+
+
+//// [jsxRuntimeDeclarationEmit.d.ts]
+// Test case to reproduce jsx-runtime declaration emit issue
+// This should trigger the jsx-runtime import without type annotation error
+export declare const FunctionComponent: () => JSX.Element;
+export declare const AnotherComponent: () => JSX.Element;
+
+
+//// [DtsFileErrors]
+
+
+jsxRuntimeDeclarationEmit.d.ts(3,47): error TS2503: Cannot find namespace 'JSX'.
+jsxRuntimeDeclarationEmit.d.ts(4,46): error TS2503: Cannot find namespace 'JSX'.
+
+
+==== jsxRuntimeDeclarationEmit.d.ts (2 errors) ====
+    // Test case to reproduce jsx-runtime declaration emit issue
+    // This should trigger the jsx-runtime import without type annotation error
+    export declare const FunctionComponent: () => JSX.Element;
+                                                  ~~~
+!!! error TS2503: Cannot find namespace 'JSX'.
+    export declare const AnotherComponent: () => JSX.Element;
+                                                 ~~~
+!!! error TS2503: Cannot find namespace 'JSX'.
+

testdata/baselines/reference/compiler/jsxRuntimeDeclarationEmit.symbols

@@ -0,0 +1,24 @@
+//// [tests/cases/compiler/jsxRuntimeDeclarationEmit.tsx] ////
+
+=== jsxRuntimeDeclarationEmit.tsx ===
+// Test case to reproduce jsx-runtime declaration emit issue
+
+
+/// <reference path="react16.d.ts" />
+
+// This should trigger the jsx-runtime import without type annotation error
+
+export const FunctionComponent = () => {
+>FunctionComponent : Symbol(FunctionComponent, Decl(jsxRuntimeDeclarationEmit.tsx, 7, 12))
+
+  return <div>Hello World</div>
+>div : Symbol(div, Decl(react16.d.ts, 2546, 114))
+>div : Symbol(div, Decl(react16.d.ts, 2546, 114))
+}
+
+export const AnotherComponent = () => {
+>AnotherComponent : Symbol(AnotherComponent, Decl(jsxRuntimeDeclarationEmit.tsx, 11, 12))
+
+  return <FunctionComponent />
+>FunctionComponent : Symbol(FunctionComponent, Decl(jsxRuntimeDeclarationEmit.tsx, 7, 12))
+}

testdata/baselines/reference/compiler/jsxRuntimeDeclarationEmit.types

@@ -0,0 +1,28 @@
+//// [tests/cases/compiler/jsxRuntimeDeclarationEmit.tsx] ////
+
+=== jsxRuntimeDeclarationEmit.tsx ===
+// Test case to reproduce jsx-runtime declaration emit issue
+
+
+/// <reference path="react16.d.ts" />
+
+// This should trigger the jsx-runtime import without type annotation error
+
+export const FunctionComponent = () => {
+>FunctionComponent : () => JSX.Element
+>() => {  return <div>Hello World</div>} : () => JSX.Element
+
+  return <div>Hello World</div>
+><div>Hello World</div> : JSX.Element
+>div : any
+>div : any
+}
+
+export const AnotherComponent = () => {
+>AnotherComponent : () => JSX.Element
+>() => {  return <FunctionComponent />} : () => JSX.Element
+
+  return <FunctionComponent />
+><FunctionComponent /> : JSX.Element
+>FunctionComponent : () => JSX.Element
+}

testdata/tests/cases/compiler/jsxRuntimeDeclarationEmit.tsx

@@ -0,0 +1,20 @@
+// Test case to reproduce jsx-runtime declaration emit issue
+
+// @jsx: react-jsx
+// @declaration: true  
+// @emitDeclarationOnly: true
+// @strict: true
+// @target: esnext
+// @module: esnext
+
+/// <reference path="/.lib/react16.d.ts" />
+
+// This should trigger the jsx-runtime import without type annotation error
+
+export const FunctionComponent = () => {
+  return <div>Hello World</div>
+}
+
+export const AnotherComponent = () => {
+  return <FunctionComponent />
+}