Skip to content

Port TS PR 60490 #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Port TS PR 60490 #1255

wants to merge 1 commit into from

Conversation

jakebailey
Copy link
Member

@Copilot Copilot AI review requested due to automatic review settings June 21, 2025 06:48
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ports changes from the upstream TypeScript PR 60490, updating baseline error outputs for classes extending or implementing primitive types and refining the internal error-checking logic.

  • Updated expected error outputs in both conformance and compiler baseline files for classes extending or implementing primitives.
  • Refactored error-checking logic in the internal checker to use ast.IsClassLike instead of a strict Kind comparison.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
testdata/baselines/reference/submodule/conformance/classExtendingPrimitive.errors.txt.diff Removed outdated diff content as part of the updated expected error outputs.
testdata/baselines/reference/submodule/conformance/classExtendingPrimitive.errors.txt Updated expected error outputs for classes extending primitive types (error count increased).
testdata/baselines/reference/submodule/compiler/classImplementsPrimitive.errors.txt.diff Removed outdated diff content as part of the revised expected error outputs.
testdata/baselines/reference/submodule/compiler/classImplementsPrimitive.errors.txt Updated expected error outputs for classes implementing primitive types (error count increased).
internal/checker/checker.go Refactored error-checking conditions to use ast.IsClassLike, aligning with the new handling of class-like constructs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant