Port completion fixes for JSX scanning #1275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ports completion fixes for JSX scanning by updating token type comparisons to align with newer AST definitions.
- Replaces comparisons using ast.KindSlashToken with ast.KindLessThanSlashToken in multiple conditions
- Updates the logic in functions getCompletionData, isValidTrigger, and getJsxClosingTagCompletion to reflect these changes
jakebailey
approved these changes
Jun 23, 2025
This was referenced Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port the fixes from microsoft/TypeScript#61928.
This fixes a completions unit test that is failing in another branch that I have, and I'm not sure why that test wasn't failing before, probably another bug in astnav code was somehow making it work.