Skip to content

Update copilot instructions and setup steps with new stuff #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 2, 2025

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jul 2, 2025

Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.

Original issue description:

The copilot-instructions.md file needs to be updated to include a few more things:

  • Specify how to run a specific compiler test.
    • For submodule tests in _submodules/TypeScript: go test -run='TestSubmodule/<test name>' ./internal/testrunner.
    • For local tests in testdata/tests/cases: go test -run='TestLocal/<test name>' ./internal/testrunner.
  • Indicate that issues with editor features cannot be tested with compiler tests in testdata/tests/cases.
  • Indicate that this code is ported from code present in _submodules/TypeScript, and so those files should be searched for similar functions when code is either missing or potentially wrong.

Also, the setup instructions yaml needs to also:

  • Run npx hereby build || true and npx hereby lint || true as well, to cache those.

Fixes #1349.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@jakebailey
Copy link
Member

Try again.

Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jul 2, 2025

Try again.

I've now implemented all the requested changes:

  1. Updated copilot-instructions.md with specific test running commands, editor testing notes, and code porting reference
  2. Added build and lint caching steps to the setup workflow

Changes made in commit 7d45508.

Copilot finished work on behalf of jakebailey July 2, 2025 16:29
@jakebailey
Copy link
Member

Unfortunately, you broke the line endings of the file. Flip the file back to CRLF (try unix2dos).

Additionally, also modify the setup instructions yaml to specify a Go version of >=1.25.0-rc.1, with a comment noting that this was done to improve compilation time.

Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jul 2, 2025

Unfortunately, you broke the line endings of the file. Flip the file back to CRLF (try unix2dos).

Additionally, also modify the setup instructions yaml to specify a Go version of >=1.25.0-rc.1,...

Fixed the line endings for copilot-instructions.md using unix2dos and updated the Go version to >=1.25.0-rc.1 with a comment about compilation time improvement as requested. Changes made in commit 5d8ce8c.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • esm.ubuntu.com
    • Triggering command: /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot finished work on behalf of jakebailey July 2, 2025 16:44
…ction

Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
@Copilot Copilot AI requested a review from jakebailey July 2, 2025 16:54
Copilot finished work on behalf of jakebailey July 2, 2025 16:54
@jakebailey jakebailey changed the title [WIP] Update copilot instructions and setup steps with new stuff Update copilot instructions and setup steps with new stuff Jul 2, 2025
@jakebailey jakebailey marked this pull request as ready for review July 2, 2025 16:57
…ing section, use npx hereby

Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jul 2, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • esm.ubuntu.com
    • Triggering command: /usr/lib/apt/methods/https (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@Copilot Copilot AI requested a review from jakebailey July 2, 2025 17:21
Copilot finished work on behalf of jakebailey July 2, 2025 17:21
Co-authored-by: jakebailey <5341706+jakebailey@users.noreply.github.com>
@Copilot Copilot AI requested a review from jakebailey July 2, 2025 17:33
Copilot finished work on behalf of jakebailey July 2, 2025 17:33
@jakebailey jakebailey added this pull request to the merge queue Jul 2, 2025
Merged via the queue into main with commit 6faf496 Jul 2, 2025
22 checks passed
@jakebailey jakebailey deleted the copilot/fix-1349 branch July 2, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update copilot instructions and setup steps with new stuff
4 participants