Make projecttestutil.Setup generic, avoid casts.

[DanielRosenwasser]

Noticed the use of map[string]any in #1339, thought it was kind of fishy.

[Copilot]

Pull Request Overview

This PR generalizes the projecttestutil.Setup and its helper to accept a map of any file-content type, and updates all existing tests to use map[string]string instead of map[string]any, removing the need for type assertions.

• Make Setup and newProjectServiceHost generic over file content type.
• Change all test files to use map[string]string and drop . (string) casts.
• Ensure language/service tests pass with updated call signatures.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
internal/testutil/projecttestutil/projecttestutil.go	Made Setup and newProjectServiceHost generic.
internal/project/service_test.go	Switched from map[string]any to map[string]string.
internal/project/ata_test.go	Switched from map[string]any to map[string]string.
internal/ls/signaturehelp_test.go	Updated createLanguageService calls to use string maps.
internal/ls/findallreferences_test.go	Same map[string]string update for references tests.
internal/ls/definition_test.go	Updated definition tests to new map type.
internal/ls/completions_test.go	Adjusted completions test helper to map[string]string.

Comments suppressed due to low confidence (2)

internal/testutil/projecttestutil/projecttestutil.go:89

• [nitpick] Consider renaming the type parameter FileContents to a shorter conventional identifier like T or C to align with common Go generics style.

func Setup[FileContents any](files map[string]FileContents, testOptions *TestTypingsInstaller) (*project.Service, *ProjectServiceHost) {

internal/testutil/projecttestutil/projecttestutil.go:89

• If only strings (or bytes) are supported for file contents, consider constraining FileContents to ~string or []byte to catch misuse at compile time.

func Setup[FileContents any](files map[string]FileContents, testOptions *TestTypingsInstaller) (*project.Service, *ProjectServiceHost) {