Make SourceFileAffectingCompilerOptions hold fully computed values, use in binder #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebailey
changed the title
jakebailey
commented
Apr 10, 2025
| AllowUnusedLabels: options.AllowUnusedLabels, | ||
| PreserveConstEnums: options.PreserveConstEnums, | ||
| IsolatedModules: options.IsolatedModules, | ||
| func (options *CompilerOptions) SourceFileAffecting() *SourceFileAffectingCompilerOptions { |
There was a problem hiding this comment.
This is not cached anywhere since we'd have to put it on CompilerOptions, which means sync.Once, which means no more DeepEqual.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jakebailey
commented
Apr 10, 2025
| AllowUnusedLabels: options.AllowUnusedLabels, | ||
| PreserveConstEnums: options.PreserveConstEnums, | ||
| IsolatedModules: options.IsolatedModules, | ||
| func (options *CompilerOptions) SourceFileAffecting() *SourceFileAffectingCompilerOptions { |
There was a problem hiding this comment.
I'm not sure if this should continue to be a value type or not, since we pass it around and so on. But it's not that large, actually.
There was a problem hiding this comment.
I tested and it keeping it a value doesn't actually hurt or help perf, so I could do that.
andrewbranch
approved these changes
Apr 10, 2025
jakebailey
commented
Apr 10, 2025
| @@ -1331,7 +1331,7 @@ func (b *Binder) checkStrictModeWithStatement(node *ast.Node) { | |||
|
|
|||
| func (b *Binder) checkStrictModeLabeledStatement(node *ast.Node) { | |||
| // Grammar checking for labeledStatement | |||
| if b.inStrictMode && b.options.Target >= core.ScriptTargetES2015 { | |||
| if b.inStrictMode && b.options.EmitScriptTarget >= core.ScriptTargetES2015 { | |||
There was a problem hiding this comment.
This is a porting bug I'm fixing, FWIW.
shinichy
pushed a commit
to shinichy/typescript-go
that referenced
this pull request
Apr 12, 2025
…se in binder (microsoft#788) Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
SourceFileAffectingCompilerOptionsconsist of only fully computed values (in prep for some other changes).SourceFileAffectingCompilerOptionsis smaller, allowing much more AST reuse.The AST reuse results in the tests running 20-25% faster, and using 1GB less peak memory.
psrecord before:
psrecord after:
Before, it's maybe 8GB, before maybe 7GB.