Skip to content

fix: Allow github.com auth when github-enterprise.uri is set #7002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dyhagho
Copy link

@dyhagho dyhagho commented Jun 2, 2025

Problem

Since version 0.110.0, setting the following configuration:

"github-enterprise.uri": "https://someghe.com"

causes the github.com authentication flow to be skipped entirely. This results in:

  • No prompt to authenticate with github.com
  • Pull Request extension for github.com repos breaking silently

For many developers (including myself), contributing to both github.com and a company-hosted GitHub Enterprise is common.

Even though the config can be set per workspace, it can be tedious to maintain across multiple repositories.
And, in practice, setting github-enterprise.uri in user settings makes more sense. But this intentionally disables github.com functionality with the current logic.

What does change?

This PR updates doCreate so that github.com is initialized even though the enterprise URI is configured.
This mirrors pre-0.110.0 behavior.

Before

before

After

after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant