fix: Allow github.com auth when github-enterprise.uri
is set
#7002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Since version
0.110.0
, setting the following configuration:causes the github.com authentication flow to be skipped entirely. This results in:
github.com
github.com
repos breaking silentlyFor many developers (including myself), contributing to both
github.com
and a company-hosted GitHub Enterprise is common.Even though the config can be set per workspace, it can be tedious to maintain across multiple repositories.
And, in practice, setting
github-enterprise.uri
in user settings makes more sense. But this intentionally disableshub.490633.xyz
functionality with the current logic.What does change?
This PR updates
doCreate
so that github.com is initialized even though the enterprise URI is configured.This mirrors pre-
0.110.0
behavior.Before
After