PHPC-2023 and PHPC-2030: Allow observation of events dispatched during client destruction #1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
commented
Jan 13, 2022
| /* If we are in request shutdown, disable APM to avoid dispatching more | ||
| * events. This means that certain events (e.g. TopologyClosedEvent, | ||
| * command monitoring for endSessions) may not be observed. */ | ||
| if (EG(flags) & EG_FLAGS_IN_SHUTDOWN) { |
There was a problem hiding this comment.
@sgolemon: If I may pick your brain for a moment: Is this something we can reasonably rely on going forward? It's hard to tell what's public and private in the Zend headers, but this seemed pretty accessible.
There was a problem hiding this comment.
Per slack. This seems to be the best you'll get for now. :(
Will followup with php-internals about this though.
Observation is only possible for non-persistent clients freed before RSHUTDOWN. This change also allows for reliable testing of ServerClosedEvent.
Command monitoring events can only be observed for non-persistent clients freed before RSHUTDOWN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-2023
https://jira.mongodb.org/browse/PHPC-2030