Skip to content

CLOUDP-314920 Telemetry for Custom Roles #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jun 18, 2025
Merged

CLOUDP-314920 Telemetry for Custom Roles #159

merged 24 commits into from
Jun 18, 2025

Conversation

MaciejKaras
Copy link
Collaborator

@MaciejKaras MaciejKaras commented May 23, 2025 •
edited
Loading

Summary

Adds Telemetry support for Custom Roles. New field customRoles can take one of values:

  • CustomRoleNone = "None"
  • CustomRoleEmbedded = "Embedded"
  • CustomRoleReferenced = "Referenced"

Proof of Work

Passing unit tests.

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@MaciejKaras MaciejKaras changed the base branch from master to custom-roles May 23, 2025 14:00
@MaciejKaras MaciejKaras marked this pull request as ready for review May 23, 2025 14:02
@MaciejKaras MaciejKaras requested a review from a team as a code owner May 23, 2025 14:02
@MaciejKaras MaciejKaras requested review from nammn and Julien-Ben and removed request for a team May 23, 2025 14:02
lucian-tosa and others added 3 commits June 6, 2025 12:11
@lucian-tosa
Merge branch 'master' into custom-roles
ff60fe4 
# Conflicts:
#	.evergreen.yml
#	api/v1/mdb/zz_generated.deepcopy.go
#	controllers/om/deployment.go
@lucian-tosa
Fix PROJECT file
57bf053
@MaciejKaras
CLOUDP-314920 Telemetry for Custom Roles
30cead7
@MaciejKaras MaciejKaras force-pushed the feature/mk-custom-roles-telemetry branch from aa21b03 to 30cead7 Compare June 10, 2025 11:35
Base automatically changed from custom-roles to master June 18, 2025 09:03
@lucian-tosa lucian-tosa merged commit c242836 into master Jun 18, 2025
35 checks passed
@lucian-tosa lucian-tosa deleted the feature/mk-custom-roles-telemetry branch June 18, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Julien-Ben Julien-Ben Julien-Ben approved these changes

@lucian-tosa lucian-tosa lucian-tosa approved these changes

@vinilage vinilage vinilage approved these changes

@nammn nammn Awaiting requested review from nammn nammn is a code owner automatically assigned from mongodb/kubernetes-hosted

@dan-mckean dan-mckean Awaiting requested review from dan-mckean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaciejKaras @Julien-Ben @lucian-tosa @vinilage