Rename init container #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucian-tosa
reviewed
Apr 30, 2025
There was a problem hiding this comment.
There might be the same mistake with init-database: https://github.com/mongodb/mongodb-kubernetes/blob/master/controllers/operator/construct/database_construction.go#L51
anandsyncs
reviewed
May 13, 2025
MaciejKaras
approved these changes
May 16, 2025
anandsyncs
approved these changes
May 19, 2025
lucian-tosa
approved these changes
May 19, 2025
mircea-cosbuc
pushed a commit
that referenced
this pull request
May 21, 2025
# Summary All our init images have been renamed from mongodb-enterprise- to mongodb-kubernetes- There was a mistake in `controllers/operator/construct/appdb_construction.go` --------- Co-authored-by: Maciej Karaś <6159874+MaciejKaras@users.noreply.github.com> Co-authored-by: Maciej Karaś <maciej.karas@mongodb.com> Co-authored-by: Anand <13899132+anandsyncs@users.noreply.github.com>
mircea-cosbuc
pushed a commit
that referenced
this pull request
May 21, 2025
# Summary All our init images have been renamed from mongodb-enterprise- to mongodb-kubernetes- There was a mistake in `controllers/operator/construct/appdb_construction.go` --------- Co-authored-by: Maciej Karaś <6159874+MaciejKaras@users.noreply.github.com> Co-authored-by: Maciej Karaś <maciej.karas@mongodb.com> Co-authored-by: Anand <13899132+anandsyncs@users.noreply.github.com>
mircea-cosbuc
added a commit
that referenced
this pull request
May 21, 2025
# Summary All our init images have been renamed from mongodb-enterprise- to mongodb-kubernetes- There was a mistake in `controllers/operator/construct/appdb_construction.go` --------- # Summary <!-- Enter your issue summary here.--> ## Proof of Work <!-- Enter your proof that it works here.--> ## Checklist - [ ] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [ ] Have you checked for release_note changes? ## Reminder (Please remove this when merging) - Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible - Our Short Guide for PRs: [Link](https://docs.google.com/document/d/1T93KUtdvONq43vfTfUt8l92uo4e4SEEvFbIEKOxGr44/edit?tab=t.0) - Remember the following Communication Standards - use comment prefixes for clarity: * **blocking**: Must be addressed before approval. * **follow-up**: Can be addressed in a later PR or ticket. * **q**: Clarifying question. * **nit**: Non-blocking suggestions. * **note**: Side-note, non-actionable. Example: Praise * --> no prefix is considered a question Co-authored-by: Julien-Ben <33035980+Julien-Ben@users.noreply.github.com> Co-authored-by: Maciej Karaś <6159874+MaciejKaras@users.noreply.github.com> Co-authored-by: Maciej Karaś <maciej.karas@mongodb.com> Co-authored-by: Anand <13899132+anandsyncs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
All our init images have been renamed from mongodb-enterprise- to mongodb-kubernetes-
There was a mistake in
controllers/operator/construct/appdb_construction.go