-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(NODE-5102): fix listDatabases nameOnly setting is sent as NaN #3742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b76e8b1
fix(NODE-5102): coercing the nameOnly option for listDatabases to a b…
redixhumayun 2d9ad3b
fix(NODE-5102): Fix review suggestions and add int tests
W-A-James 36d3cdb
style(NODE-5102): eslint
W-A-James ec97606
test(NODE-5102): fix unit tests
W-A-James 426d04b
test(NODE-5102): update int tests and fix unit test nit
W-A-James b2dbc3c
test(NODE-5102): streamline tests
W-A-James 41ea030
test(NODE-5102): add default case
W-A-James 28830ae
Merge branch 'main' into NODE-5102
W-A-James File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
import { expect } from 'chai'; | ||
|
||
import { ListDatabasesOperation, MongoDBNamespace } from '../../mongodb'; | ||
|
||
const mockDB = { | ||
s: { | ||
namespace: { | ||
withCollection() { | ||
return new MongoDBNamespace('test', 'test'); | ||
} | ||
} | ||
} | ||
}; | ||
|
||
describe('ListDatabasesOperation', function () { | ||
describe('#constructor', function () { | ||
context('when nameOnly is provided', function () { | ||
context('when nameOnly is true', function () { | ||
const operation = new ListDatabasesOperation(mockDB, { nameOnly: true }); | ||
W-A-James marked this conversation as resolved.
Show resolved
Hide resolved
|
||
it('sets nameOnly to true', function () { | ||
expect(operation.options).to.have.property('nameOnly', true); | ||
}); | ||
}); | ||
|
||
context('when nameOnly is false', function () { | ||
const operation = new ListDatabasesOperation(mockDB, { nameOnly: false }); | ||
|
||
it('sets nameOnly to false', function () { | ||
expect(operation.options).to.have.property('nameOnly', false); | ||
}); | ||
}); | ||
}); | ||
|
||
context('when nameOnly is not specified', function () { | ||
const operation = new ListDatabasesOperation(mockDB, {}); | ||
|
||
it('nameOnly is undefined', function () { | ||
expect(operation.options).not.to.have.property('nameOnly'); | ||
}); | ||
}); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.