Implement ids generator for OrderMatchingEngine in Rust #2193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipmacek
force-pushed
the
ids-generator-order-matching-engine
branch
2 times, most recently
from
ece925b to
51dee37
Compare
filipmacek
force-pushed
the
ids-generator-order-matching-engine
branch
from
51dee37 to
c5bfd17
Compare
cjdsellers
approved these changes
Jan 8, 2025
Pushkarm029
pushed a commit
to Pushkarm029/nautilus_trader
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
OrderMatchingEnginethat can be separated into its own struct calledIdsGenerator. This approach is easier to maintain and tests