Group polymarket subscriptions by configurable delay #2271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid overwhelming polymarket by establishing many WS at once, since polymarket will throw 429 at us. We separate out the initial delay and the non-initial delay just in case users wanting more fine-grained control about the delay.
cjdsellers
changed the title
|
Hi @ryantam626 Great work, and thanks for the contribution 🙏 I'll make sure to communicate the config meaning change in the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Allow user to configure the delay of non-initial Polymarket WS connection per #2238
This is to avoid overwhelming polymarket by establishing many WS at once, since polymarket will throw 429 at us.
We separate out the initial delay and the non-initial delay just in case users wanting more fine-grained control about the delay.
N.B.
ws_connection_delay_secshas a new meaning now - this is no longer the config for the initial delay but for non-intiial WS connection delay - this might need to be communicated to end users.Type of change
How has this change been tested?
Built and ran locally against polymarket.