Refine bar aggregators in Rust #2311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjdsellers
changed the title
cjdsellers
reviewed
Feb 11, 2025
| match callback { | ||
| Some(callback_py) => self.callbacks.insert(name_ustr, callback_py), | ||
| None => None, | ||
| }; | ||
|
|
||
| let ts_now = self.time.get_time_ns(); | ||
| // This allows to reuse a time alert without updating the callback, for example for non regular monthly alerts. |
There was a problem hiding this comment.
We could also push this logic here down to Rust, as I think it is achieving the same thing.
(can be in a follow-up PR.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Refine rust bar aggregators
I've also done some changes to TestClock and LiveClock in order to be able to update a time alert without having to pass again a callback, which would be tricky if an object needs to pass a callback to itself.
Type of change
How has this change been tested?
Existing tests pass